ci: Make Windows Defender step best-effort on Windows runners#103
Merged
Conversation
andrew
approved these changes
Jun 29, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
Thanks for splitting this out. -ErrorAction Stop + try/catch is the right shape so non-terminating errors actually hit the catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
.github/workflows/ci.ymlto make the step that disables Windows Defender real-time monitoring a "best-effort" operation.Previously, if
Set-MpPreferencefailed (due to runner permission restrictions, environment updates, or transient issues), it would cause the entire CI pipeline to fail on Windows. By wrapping this command in a PowerShelltry/catchblock, we ensure that any failures simply emit a warning rather than hard-crashing and interrupting the subsequent build and test steps.Note: This change was originally included as part of #96, but was extracted into this standalone PR as requested here #96 (review).